This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Merge pai config #1965
Merged
Merge pai config #1965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge master
merge master
Update evolution doc (microsoft#1493)
merge master
merge master
merge master
augment pylintrc (microsoft#1643)
fix console.log (microsoft#1636)
merge master
merge master
merge master
merge master
Filter prune algo implementation (microsoft#1655)
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
Support monitor mode when creating or resuming a new experiment (microsoft#1933)
Add test for documentation build (microsoft#1924)
fix pipeline status badge (microsoft#1942)
SparkSnail
requested review from
acblacktea and
liuzhe-lz
and removed request for
acblacktea
QuanluZhang
reviewed
Jan 17, 2020
QuanluZhang
reviewed
Jan 17, 2020
| const additionalPAIConfig = yaml.safeLoad(fs.readFileSync(this.paiTrialConfig.paiConfigPath, 'utf8')); | ||
| return yaml.safeDump({...paiJobConfig, ...additionalPAIConfig}); | ||
| } catch (error) { | ||
| this.log.error(`Loading ${this.paiTrialConfig.paiConfigPath} error: ${error}`); |
There was a problem hiding this comment.
this error message is not accurate, could be:
error occurs during loading and merge .... : ${error}
liuzhe-lz
reviewed
Jan 19, 2020
src/nni_manager/package.json
Outdated
| @@ -26,7 +26,8 @@ | |||
| "ts-deferred": "^1.0.4", | |||
| "typescript-ioc": "^1.2.4", | |||
| "typescript-string-operations": "^1.3.1", | |||
| "webhdfs": "^1.2.0" | |||
| "webhdfs": "^1.2.0", | |||
| "deepmerge": "^4.2.2" | |||
There was a problem hiding this comment.
Looks like your are not using yarn add
There was a problem hiding this comment.
Looks like your are not using
yarn add
fixed.
QuanluZhang
approved these changes
Jan 19, 2020
chicm-ms
reviewed
Feb 4, 2020
| @@ -13,6 +13,7 @@ | |||
| "azure-storage": "^2.10.2", | |||
| "chai-as-promised": "^7.1.1", | |||
| "child-process-promise": "^2.2.1", | |||
| "deepmerge": "^4.2.2", | |||
There was a problem hiding this comment.
there should be some updates in yarn.lock needs to be checked in.
added 2 commits
February 5, 2020 11:48
chicm-ms
approved these changes
Feb 7, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.