This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Refine doc and fix bug for testing MedianstopAssessor #1998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuehui1991
approved these changes
Feb 6, 2020
QuanluZhang
reviewed
Feb 7, 2020
| #lc = [] | ||
| to_complete = True | ||
| for k in range(10): | ||
| for k in range(FLAGS.start_step): |
There was a problem hiding this comment.
FLAGS.start_step -> len(lcs[0])
There was a problem hiding this comment.
FLAGS.start_step is internal used by MedianstopAssessor
QuanluZhang
reviewed
Feb 7, 2020
| Medianstop 是一种简单的提前终止 Trial 的策略，可参考[论文](https://static.googleusercontent.com/media/research.google.com/en//pubs/archive/46180.pdf)。 如果 Trial X 在步骤 S 的最好目标值低于所有已完成 Trial 前S个步骤目标平均值的中位数，这个 Trial 就会被提前停止。 |
There was a problem hiding this comment.
thanks for your fix, but could you revert this change, because we have a dedicated pipeline for the update of chinese doc
There was a problem hiding this comment.
we will update this part later :)
This reverts commit 28b8b70.
QuanluZhang
approved these changes
Feb 7, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.