This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Fix windows pipeline timeout #2050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chicm-ms
requested review from
SparkSnail,
QuanluZhang,
BrightBryan,
xuehui1991,
ultmaster and
liuzhe-lz
and removed request for
BrightBryan
QuanluZhang
reviewed
Feb 12, 2020
| @@ -176,6 +179,7 @@ def test(epoch): | |||
| if __name__ == '__main__': | |||
| parser = argparse.ArgumentParser() | |||
| parser.add_argument("--epochs", type=int, default=200) | |||
| parser.add_argument("--batches", type=int, default=-1) | |||
There was a problem hiding this comment.
better to add comments to tell this argument is for integration test
There was a problem hiding this comment.
Thanks, comments added.
QuanluZhang
approved these changes
Feb 12, 2020
xuehui1991
approved these changes
Feb 12, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.