This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Update WebUI for metrics data changing to json string #2067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chicm-ms
reviewed
Feb 17, 2020
src/webui/src/static/function.ts
Outdated
| @@ -43,7 +43,7 @@ const getFinalResult = (final?: MetricDataRecord[]): number => { | |||
| let acc; | |||
| let showDefault = 0; | |||
| if (final) { | |||
| acc = JSON.parse(final[final.length - 1].data); | |||
| acc = JSON5.parse(final[final.length - 1].data); | |||
There was a problem hiding this comment.
Is it possible to call parseMetrics here? there maybe more updates in parseMetrics later.
chicm-ms
reviewed
Feb 17, 2020
| @@ -182,8 +182,6 @@ function formatTimestamp(timestamp?: number, placeholder?: string): string { | |||
| function parseMetrics(metricData: string): any { | |||
| if (metricData.includes('NaN')) { | |||
| return JSON5.parse(metricData) | |||
| } else { | |||
| return JSON.parse(metricData) | |||
There was a problem hiding this comment.
I thought UI only use JSON5 from the teams message.
It's misleading, I'll change this back.
chicm-ms
reviewed
Feb 17, 2020
src/webui/src/static/function.ts
Outdated
| @@ -61,7 +61,7 @@ const getFinalResult = (final?: MetricDataRecord[]): number => { | |||
| const getFinal = (final?: MetricDataRecord[]): FinalType | undefined => { | |||
| let showDefault: FinalType; | |||
| if (final) { | |||
| showDefault = JSON.parse(final[final.length - 1].data); | |||
| showDefault = JSON5.parse(final[final.length - 1].data); | |||
There was a problem hiding this comment.
Can this be replaced by parseMetrics?
liuzhe-lz
approved these changes
Feb 17, 2020
chicm-ms
changed the title
chicm-ms
approved these changes
Feb 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update WebUI for metrics data changing to json string