This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Integration tests for NAS #2231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chicm-ms
approved these changes
Mar 25, 2020
QuanluZhang
approved these changes
Mar 27, 2020
conda activate nnidev Merge remote-tracking branch 'privileged/master' into dev-nas-it
|
I’m merging it first. UT on IT still pending fix. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests cover:
I'm not gonna finish the tests for other examples in this release, because
The tests take ~25min on our pipeline, lengthening our pipeline to ~80min. I tried to reduce this time with minimum configurations (minimum epochs, minimum channels). Perhaps it can be further optimized without intrusive modification to example code, but it's not trivial to me.