This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
[BUG] finding leaf modules #2241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ultmaster
approved these changes
Mar 27, 2020
| if node.sname[-1] == ']': | ||
| leaf_nodes.append(sn) | ||
| else: | ||
| for key in node.childs: |
There was a problem hiding this comment.
for child in node.children.values():
traverse_tree(child, sn)| for key in node.childs: | ||
| traverse_tree(node.childs[key], sn) | ||
| traverse_tree(root, '') | ||
| return leaf_nodes |
There was a problem hiding this comment.
If I'm right, what this is doing is actually: finding all leaf nodes that ends with ]. If so, there is a simpler way to do it:
all_names = [node.scopeName() for node in graph.nodes()]
all_names = list(filter(lambda x: x, all_names)) # filter out non-empty strings
all_names.sort()
leaf_nodes = []
for i, name in enumerate(all_names):
if (i + 1 >= len(all_names) or not all_names[i + 1].startswith(name)) and name.endswith("]"):
leaf_nodes.append(name)
return leaf_nodesSince I didn't get enough context, I might be wrong...
There was a problem hiding this comment.
I test both your functions, they can generate same results.
There was a problem hiding this comment.
@ultmaster too complex, I am not sure whether the logic is correct or not...
chicm-ms
approved these changes
Mar 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.