This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
fix #1578 and some improvements #2370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
April 21, 2020 17:22
fix gpu_metrics_collector to support pyenv fix NASUI failure on dev-install-node-modules add .gitignore links for dev-install
squirrelsc
requested review from
SparkSnail,
chicm-ms,
ultmaster,
QuanluZhang,
leckie-chn and
liuzhe-lz
ultmaster
approved these changes
Apr 26, 2020
SparkSnail
reviewed
Apr 26, 2020
| if (useShell) { | ||
| captureStdOut = true; | ||
| channel.stdin.write(`${command}\n`); | ||
| captureStdOut = false; |
There was a problem hiding this comment.
Firstly set captureStdOut = true, then set captureStdOut = false, what is the purpose of this operation?
There was a problem hiding this comment.
It used to reduce output in log, but it may bring confusing. So removed this flag.
SparkSnail
reviewed
Apr 26, 2020
| }; | ||
|
|
||
| if (useShell) { | ||
| client.shell(callback); |
There was a problem hiding this comment.
how to exec command in client.shell?
There was a problem hiding this comment.
It supports in ssh2 package, and the command will be send in 'ready' event as above lines
if (useShell) {
channel.stdin.write(`${command}\n`);
channel.end("exit\n");
}
SparkSnail
approved these changes
Apr 26, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add shell support for ssh connection, so that remote script can be started with user environment.
Minor fixes,
#1578