This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
refactor: update eslint rules to remove warnings during build #2405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and fix all violations
QuanluZhang
reviewed
May 7, 2020
| if ((error !== undefined && error !== null) || response.statusCode >= 400) { | ||
| const errorMessage: string = (error !== undefined && error !== null) ? error.message : |
There was a problem hiding this comment.
@SparkSnail This errorMessage is not used?
There was a problem hiding this comment.
Seems only have declare of errorMessage, and this.log.error(errorMessage) is missing for some reason. I think it's better to add this.log.error(errorMessage) instead of deleting it.
QuanluZhang
approved these changes
May 7, 2020
chicm-ms
approved these changes
May 7, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update nni manager eslint rules.