This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
fix chmod bug #2689
Merged
fix chmod bug #2689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SparkSnail
reviewed
Jul 15, 2020
| let command; | ||
|
|
||
| if (isRecursive) { | ||
| command = `chmod 777 -R '${folderString}'`; | ||
| command = `chmod 777 -R ${folderString}`; |
There was a problem hiding this comment.
because shell can not expand wildcard in single quotes. For example, this line can not be executed correctly:
chmod 777 '/tmp/nni/*'
This pr will change the command to
chmod 777 /tmp/nni/*
SparkSnail
approved these changes
Jul 15, 2020
liuzhe-lz
approved these changes
Jul 15, 2020
|
The ideal solution should be setting shared permission on creation. Though we might need to keep |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original allowPermission can not handle strings with wildcard, remove single quotes from the original function.