This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Add WebUI mock server and improve hyper-parameter parallel coordinates chart #2691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colorjam
approved these changes
Jul 22, 2020
| @@ -48,7 +48,8 @@ Nothing to do, the code is already linked to package folders. | |||
| #### TypeScript | |||
|
|
|||
| * If `src/nni_manager` is changed, run `yarn watch` under this folder. It will watch and build code continually. The `nnictl` need to be restarted to reload NNI manager. | |||
| * If `src/webui` or `src/nasui` are changed, run `yarn start` under the corresponding folder. The web UI will refresh automatically if code is changed. | |||
| * If `src/webui` is changed, run `yarn dev`, which will run a mock API server and a webpack dev server simultaneously. Use `EXPERIMENT` environment variable (e.g., `mnist-tfv1-running`) to change mock data. Built-in mock experiments are listed in `src/webui/mock`. | |||
There was a problem hiding this comment.
better to provide the entire command such as EXPERIMENT=mnist-tfv1-running yarn dev
Lijiaoa
reviewed
Jul 23, 2020
| @@ -0,0 +1,6 @@ | |||
| .parcoords { | |||
| text.label, text { | |||
| font-family: "Segoe UI", "Segoe UI Web (West European)", "Segoe UI", -apple-system, BlinkMacSystemFont, Roboto, "Helvetica Neue", sans-serif; | |||
| if (this.acc === undefined) { | ||
| return ret; | ||
| } | ||
| const acc = typeof this.acc === 'number' ? { default: this.acc } : this.acc; |
There was a problem hiding this comment.
accDictionary in source is === your acc
| if (trial.acc === undefined) | ||
| continue; | ||
| // TODO: handle more than number and object | ||
| const acc = typeof trial.acc === 'number' ? { default: trial.acc } : trial.acc; |
There was a problem hiding this comment.
you can use this field accDictionary in data source
|
|
||
| export class MetricSpace implements MultipleAxes { | ||
| axes = new Map<string, SingleAxis>(); | ||
| name = ''; |
There was a problem hiding this comment.
Changed to baseName
| nested = false; | ||
|
|
||
| constructor(name: string, fullName: string, type: string, value: any) { | ||
| this.name = name; |
There was a problem hiding this comment.
I think name is a sensitive name.
Comment on lines
101
to
102
| if (searchSpaceSpec === undefined) | ||
| return; |
| const key = item[0], spec = item[1] as any; | ||
| if (key === '_name') { | ||
| return; | ||
| } else if (spec._type === 'choice' || spec._type === 'layer_choice' || spec._type === 'input_choice') { |
There was a problem hiding this comment.
['x', 'xx', 'xx'].includes(spec._type)
| this.max = value[1]; | ||
| } else if (type.indexOf('normal') !== -1) { | ||
| const [mu, sigma] = [value[0], value[1]]; | ||
| this.min = mu - 4 * sigma; |
There was a problem hiding this comment.
In normal distribution, [mu - 4sigma, mu + 4sigma] is a very safe domain of the values.
| fullName: string; | ||
|
|
||
| constructor(name: string, fullName: string, searchSpaceSpec: any) { | ||
| this.name = name; |
liuzhe-lz
approved these changes
Jul 24, 2020
Lijiaoa
approved these changes
Jul 24, 2020
QuanluZhang
approved these changes
Jul 24, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.