This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Fix remote machine connection logic #2725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge master
merge master
merge master
merge master
merge master
merge master
merge master
Chinese translation (microsoft#2458)
merge master
merge master
SparkSnail
changed the title
squirrelsc
reviewed
Jul 24, 2020
| @@ -82,6 +84,12 @@ class RemoteMachineTrainingService implements TrainingService { | |||
| restServer.setEnableVersionCheck = this.versionCheck; | |||
| this.log.info('Run remote machine training service.'); | |||
| while (!this.stopping) { | |||
| if (this.sshConnectionPromises.length) { | |||
There was a problem hiding this comment.
To improve readabilty, and avoid tricks of JS, it's bettter to write like this.sshConnectionPromises.length > 0
squirrelsc
reviewed
Jul 24, 2020
| @@ -82,6 +84,12 @@ class RemoteMachineTrainingService implements TrainingService { | |||
| restServer.setEnableVersionCheck = this.versionCheck; | |||
| this.log.info('Run remote machine training service.'); | |||
| while (!this.stopping) { | |||
| if (this.sshConnectionPromises.length) { | |||
There was a problem hiding this comment.
It looks should be put outside of while loop, as it's one time work.
squirrelsc
approved these changes
Jul 24, 2020
chicm-ms
approved these changes
Aug 7, 2020
LovPe
pushed a commit
to LovPe/nni
that referenced
this pull request
Aug 17, 2020
(cherry picked from commit 109d9a3)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.