refactor experiment summary file(to fix componentWillReceiveProps waring) and click other areas to close panel #2734
Conversation
| // add intermediate result message | ||
| trialMessagesArr[item].intermediate = []; | ||
| Object.keys(interResultList).map(key => { | ||
| const interId = `${interResultList[key].trialJobId}-${interResultList[key].parameterId}`; |
There was a problem hiding this comment.
I think the id format has changed.
| .then(data => this.doUpdateMetrics(data as any, false)) | ||
| .then(data => { | ||
| this.metricsList = data; | ||
| this.doUpdateMetrics(data as any, false); |
There was a problem hiding this comment.
return this.doUpdateMetrics
There was a problem hiding this comment.
why return this function?
There was a problem hiding this comment.
ok. will return this function
| @@ -252,7 +262,8 @@ class TrialManager { | |||
| return updated; | |||
| } | |||
|
|
|||
| private async updateMetrics(lastTime?: boolean): Promise<boolean> { | |||
| private async updateMetrics(lastTime?: boolean): Promise<boolean | void> { | |||
| // private async updateMetrics(lastTime?: boolean): Promise<boolean> { | |||
There was a problem hiding this comment.
Remove unused code. Why should it be boolean | void?
There was a problem hiding this comment.
add void type to fix this error:
had delete line 266.
There was a problem hiding this comment.
finally, use line 265. Thanks.
| @@ -58,7 +67,7 @@ class TrialManager { | |||
| } | |||
| } | |||
|
|
|||
| public async update(lastTime?: boolean): Promise<boolean> { | |||
| public async update(lastTime?: boolean): Promise<boolean | void> { | |||
| {isvisibleLogDrawer && <LogDrawer closeDrawer={this.closeLogDrawer} />} | ||
| <ExperimentDrawer isVisble={isvisibleExperimentDrawer} closeExpDrawer={this.closeExpDrawer} /> | ||
| {isvisibleLogDrawer && <LogPanel closeDrawer={this.closeLogDrawer} />} | ||
| {isvisibleExperimentDrawer && <ExperimentPanel closeExpDrawer={this.closeExpDrawer} experimentProfile={EXPERIMENT.profile} />} |
There was a problem hiding this comment.
I don't know if it's proper to pass EXPERIMENT.profile (a getter function) as property. This will likely to cause ExperimentPanel get re-rendered every time.
There was a problem hiding this comment.
had tested this status. ExperimentPanel will refresh as interval not every time.
| public getMetricsList(): Array<any> { | ||
| return this.metricsList; | ||
| } | ||
| public getTrialJobList(): Array<any> { |
There was a problem hiding this comment.
Trial job should have a type.
There was a problem hiding this comment.
had fixed. add type MetricDataRecord TrialJobInfo.
| componentWillUnmount(): void { | ||
| this._isCompareMount = false; | ||
| this._isExperimentMount = false; |
…ing) and click other areas to close panel (microsoft#2734) (cherry picked from commit 2488aa6)
No description provided.