This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
update experiment dir #2753
Merged
update experiment dir #2753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ultmaster
requested review from
chicm-ms,
SparkSnail,
liuzhe-lz,
QuanluZhang and
Gerhut
Gerhut
approved these changes
Aug 3, 2020
SparkSnail
reviewed
Aug 7, 2020
| @@ -175,7 +175,7 @@ class ShellExecutor { | |||
| } | |||
|
|
|||
| public getRemoteExperimentRootDir(experimentId: string): string { | |||
| return this.joinPath(this.tempPath, 'nni', 'experiments', experimentId); | |||
| return this.joinPath(this.tempPath, 'nni-experiments', experimentId); | |||
There was a problem hiding this comment.
This is not NNI's local home path, need to confirm if there are others folder under /tmp/nni in remote machine.
QuanluZhang
approved these changes
Aug 12, 2020
SparkSnail
approved these changes
Aug 12, 2020
LovPe
pushed a commit
to LovPe/nni
that referenced
this pull request
Aug 17, 2020
(cherry picked from commit 6ec2ade)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update
nni/experimentstonni-experimentsin docs, rest server and nnictl commands.