This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Successive unpack #2768
Merged
Successive unpack #2768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 6, 2020 03:00
Signed-off-by: Ningxin <Ningxin.Zheng@microsoft.com>
Signed-off-by: Ningxin <Ningxin.Zheng@microsoft.com>
Signed-off-by: Ningxin <Ningxin.Zheng@microsoft.com>
|
Can you add unittests for this fix? |
added 2 commits
August 10, 2020 05:56
Signed-off-by: Ningxin <Ningxin.Zheng@microsoft.com>
Signed-off-by: Ningxin <Ningxin.Zheng@microsoft.com>
QuanluZhang
reviewed
Aug 10, 2020
| if _debug_output in self.input_to_node: | ||
| for following_node in self.input_to_node[_debug_output]: | ||
| _tmp_index = following_node.inputs.index(_debug_output) | ||
| following_node.inputs[_tmp_index] = _debug_input |
There was a problem hiding this comment.
much clear for this logic
QuanluZhang
approved these changes
Aug 10, 2020
chicm-ms
approved these changes
Aug 12, 2020
LovPe
pushed a commit
to LovPe/nni
that referenced
this pull request
Aug 17, 2020
(cherry picked from commit 5d2a59f)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support the multiple successive tuple unpack operations.