Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

Fix nnictl experiment delete #2791

Merged
merged 28 commits into from
Aug 14, 2020
Merged

Fix nnictl experiment delete #2791

merged 28 commits into from
Aug 14, 2020

Conversation

SparkSnail
Copy link
Contributor

No description provided.

@SparkSnail
Merge pull request #251 from microsoft/master
dcd2ffd 
Merge master
@SparkSnail
Merge pull request #252 from microsoft/master
3b8b6fb 
merge master
@SparkSnail
Merge pull request #253 from microsoft/master
916e444 
merge master
@SparkSnail
Merge pull request #254 from microsoft/master
caeffb8 
merge master
@SparkSnail
Merge pull request #255 from microsoft/master
57c300e 
merge master
@SparkSnail
Merge pull request #257 from microsoft/master
65660e6 
merge master
@SparkSnail
Merge pull request #258 from microsoft/master
9376d6a 
merge master
@SparkSnail
Merge pull request #259 from microsoft/master
5fef3cf 
Chinese translation (microsoft#2458)
@SparkSnail
Merge pull request #261 from microsoft/master
5544ae8 
merge master
@SparkSnail
Merge pull request #262 from microsoft/master
f9fdfee 
merge master
@SparkSnail
add trial job detail link
c5e26ef
@SparkSnail
Merge branch 'master' of https://github.com/SparkSnail/nni
10a04ba
@SparkSnail
Merge pull request #263 from microsoft/master
aa64fe6 
merge master
@SparkSnail
Merge branch 'master' of https://github.com/SparkSnail/nni
4ed907f
@SparkSnail
Merge pull request #264 from microsoft/master
c6a5f8c 
merge master
@SparkSnail
Merge pull request #265 from microsoft/master
68abe2f 
merge master
@SparkSnail
Merge branch 'master' of https://github.com/SparkSnail/nni
c2b50d2
@SparkSnail
fix experiment delete
1e1caa5
@ultmaster ultmaster changed the title Fix nnectl experiment delete Fix nnictl experiment delete Aug 13, 2020
chicm-ms
chicm-ms reviewed Aug 13, 2020
View reviewed changes
Copy link
Contributor

@chicm-ms chicm-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A safer way is to delete db,log,and trials one by one, then check if the exp dir is empty, delete it if it is empty

@SparkSnail
Copy link
Contributor Author

A safer way is to delete db,log,and trials one by one, then check if the exp dir is empty, delete it if it is empty

updated, although I think this way might be a little complicated, for different kind of trainingService might have different folders, and we may add more folders in logDir in the future, and need to maintain this nnictl command.

@ultmaster ultmaster merged commit bbb9137 into microsoft:master Aug 14, 2020
@ultmaster ultmaster mentioned this pull request Aug 14, 2020
Closed
66 tasks
LovPe pushed a commit to LovPe/nni that referenced this pull request Aug 17, 2020
@SparkSnail @LovPe
Fix nnictl experiment delete (microsoft#2791)
4d1a0a3 
(cherry picked from commit bbb9137)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chicm-ms chicm-ms chicm-ms approved these changes

@ultmaster ultmaster ultmaster approved these changes

@QuanluZhang QuanluZhang Awaiting requested review from QuanluZhang

@liuzhe-lz liuzhe-lz Awaiting requested review from liuzhe-lz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SparkSnail @ultmaster @chicm-ms