This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Support saving search space in experiment load&save command #2886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge master
merge master
merge master
merge master
merge master
merge master
merge master
Chinese translation (microsoft#2458)
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
SparkSnail
changed the title
ultmaster
reviewed
Sep 11, 2020
tools/nni_cmd/nnictl_utils.py
Outdated
| target_path = os.path.join(os.getcwd(), target_path) | ||
| print_normal('Expand search space path to %s' % target_path) | ||
| nnictl_exp_config['searchSpacePath'] = target_path | ||
| # if the path alerady has a search space file, use the original one, otherwise use archived one |
| print_error('Archive file does not contain search space file!') | ||
| exit(1) | ||
| else: | ||
| for file in os.listdir(archive_search_space_dir): |
There was a problem hiding this comment.
For storage data and classify. There are a few folders in archive folder, including 'code', 'nnictl', 'experiment', 'searchSpace', the search space file's name is random, put this file into 'searchSpace' folder for identify.
ultmaster
reviewed
Sep 11, 2020
| source_path = os.path.join(archive_search_space_dir, file) | ||
| os.makedirs(os.path.dirname(target_path), exist_ok=True) | ||
| shutil.copyfile(source_path, target_path) | ||
| break |
There was a problem hiding this comment.
Throw error when no file is found?
There was a problem hiding this comment.
there is already a judgement in lint 955, don't need to throw error here anymore.
79 tasks
chicm-ms
reviewed
Sep 13, 2020
tools/nni_cmd/nnictl.py
Outdated
| @@ -159,6 +159,8 @@ def parse_args(): | |||
| parser_load_experiment.add_argument('--codeDir', '-c', required=True, help='the path of codeDir for loaded experiment, \ | |||
| this path will also put the code in the loaded experiment package') | |||
| parser_load_experiment.add_argument('--logDir', '-l', required=False, help='the path of logDir for loaded experiment') | |||
| parser_load_experiment.add_argument('--searchSpacePath', '-s', required=True, help='the path of search space file for \ | |||
There was a problem hiding this comment.
Some experiments do not have search space.
Even for the experiment with search space, can we just load search space file to codeDir by default? If there is an naming conflict loading search space into codeDir, then we report error and ask use to specify --searchSpacePath.
ultmaster
approved these changes
Sep 14, 2020
QuanluZhang
reviewed
Sep 16, 2020
tools/nni_cmd/nnictl_utils.py
Outdated
| search_space_path = nni_config.get_config('experimentConfig').get('searchSpacePath') | ||
| if search_space_path: | ||
| if not os.path.exists(search_space_path): | ||
| print_error('search space %s does not exist!' % search_space_path) |
There was a problem hiding this comment.
warning might be better?
QuanluZhang
approved these changes
Sep 20, 2020
chicm-ms
approved these changes
Sep 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.