This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Upgrade node and yarn #2894
Merged
Upgrade node and yarn #2894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not suggesting to use latest yarn. I just said it's acceptable... |
liuzhe-lz
reviewed
Sep 14, 2020
| @@ -7,12 +7,13 @@ $install_yarn = $true | |||
|
|
|||
| if ([Environment]::Is64BitOperatingSystem) { | |||
| $OS_VERSION = 'win64' | |||
| $nodeUrl = "https://nodejs.org/download/release/v10.22.0/node-v10.22.0-win-x64.zip" | |||
| } | |||
| else { | |||
| $OS_VERSION = 'win32' | |||
There was a problem hiding this comment.
Wait, does NNI support 32-bit Windows?
If yes, where is the pipeline?
There was a problem hiding this comment.
IDK. I'm sure NNI doesn't support 32-bit Linux.
liuzhe-lz
approved these changes
Sep 14, 2020
Lijiaoa
approved these changes
Sep 15, 2020
Agree, suggest to use a fixed version. |
|
Suggest to run IT pipelines: windows/linux local and remote, and build pipeline. |
chicm-ms
approved these changes
Sep 16, 2020
SparkSnail
approved these changes
Sep 16, 2020
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makefile in deployment folder still needs to be updated correspondingly.Yarn will use the latest version per @liuzhe-lz 's suggestion.Node.js 10.13 -> 10.22
yarn 1.12.1 -> 1.22.5