Refactor code hierarchy part 3: Unit test #3037
Conversation
| @@ -5,6 +5,10 @@ | |||
| /test/model_path/ | |||
| /test/temp.json | |||
| /test/ut/sdk/*.pth | |||
| /test/ut/tools/annotation/_generated/ | |||
| /ts/nni_manager/exp_profile.json | |||
| /ts/nni_manager/metrics.json | |||
There was a problem hiding this comment.
why add this 3 json files?
There was a problem hiding this comment.
They are generated during unit test.
| @@ -0,0 +1,216 @@ | |||
| # To reduce debug cost, steps are sorted differently on each platform, | |||
There was a problem hiding this comment.
can't get the point, are these test cases in this file duplicated with other pipelines? when will we use this test file?
There was a problem hiding this comment.
This file is basically azure-pipelines.yml. I'm trying to do some refactor and don't want to block other PRs during development. When refactor is done, I will replace the old pipeline with this one.
| # if fc is not None: | ||
| # fc.close() | ||
|
|
||
| #def test_send_multi_node(self): |
There was a problem hiding this comment.
why annotate these functions?
There was a problem hiding this comment.
Because this test case failed and I can't fix it.
As stated in FIXME, BaseChannel.send() will raise if the second argument is a string, contradicting to it's doc, and this test case calls it with fc1.send(CommandType.ReportGpuInfo, "command1").
I think this test case was skipped in old pipeline for unknown reason.
This PR fixes most unit test cases broken by code hierarchy refactor, on Linux and macOS.
All Python UT are moved to
test/utfolder. Run them with:The new UT pipeline is placed in
pipelinesdirectory, and I will put future v2.0 pipelines there too.One important reason that I changed pipeline location is to make the transition smooth.
Once pipeline porting is done, we may either move them back to old location or just remove the old ones. This can be discussed later.
There are several broken test cases which need further investigation. You can search
FIXMEintest/utfolder to find them.UT on Windows is more problematic and is supposed to be fixed later. In fact it was not fully tested in v1.x versions.