This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
quick fix exp-duration pause timing under no_more_trial status #3043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liuzhe-lz
approved these changes
Oct 30, 2020
QuanluZhang
approved these changes
Oct 30, 2020
chicm-ms
pushed a commit
to chicm-ms/nni
that referenced
this pull request
Nov 9, 2020
…soft#3043) Co-authored-by: Ning Shang <nishang@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous situation, experiment duration only timing under
RUNNINGstatus. But this may be different from the timing expected by the user, i.e. , timing will pause underNO_MORE_TRIALandTUNER_NO_MORE_TRIALstatus with some trials still running.This PR is a quick fix that when the status is
NO_MORE_TRIALorTUNER_NO_MORE_TRIAL, let the timing continue. But maybe we need give a clearer definition aboutexecDuration.