This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
quick fix kill command under windows #3106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liuzhe-lz
reviewed
Nov 24, 2020
ts/nni_manager/main.ts
Outdated
| process.on('SIGTERM', cleanUp); | ||
| process.on('SIGBREAK', cleanUp); | ||
| process.on('SIGINT', cleanUp); | ||
| //not sure if 'SIGKILL' signal can be listened |
added 2 commits
November 24, 2020 13:35
|
@liuzhe-lz So change back to |
SparkSnail
reviewed
Nov 24, 2020
| @@ -201,7 +188,11 @@ process.on(getStopSignal(), async () => { | |||
| hasError = true; | |||
| log.error(`${err.stack}`); | |||
| } finally { | |||
| await log.close(); | |||
| log.close(); | |||
There was a problem hiding this comment.
Logger.close() is a sync function
On Windows SIGTERM does not trigger handler. It acts like SIGKILL in fact. |
SparkSnail
approved these changes
Nov 25, 2020
liuzhe-lz
approved these changes
Nov 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.