This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
support hybrid training service v2.0 config #3251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SparkSnail
reviewed
Jan 4, 2021
nni/tools/nnictl/launcher.py
Outdated
| print_error(e) | ||
| exit(1) | ||
| except Exception: | ||
| print_warning('Validation with V1 schema failed. Trying to convert from V2 format...') |
There was a problem hiding this comment.
When use V2 yaml file, there always be a warning here?
There was a problem hiding this comment.
yes, this is a content that I merge from yuge's pr. I think it is okay for now
SparkSnail
approved these changes
Jan 4, 2021
liuzhe-lz
approved these changes
Jan 5, 2021
QuanluZhang
commented
Jan 5, 2021
| @@ -7,6 +7,8 @@ trainingServicePlatform: hybrid | |||
| searchSpacePath: search_space.json | |||
| #choice: true, false | |||
| useAnnotation: false | |||
| nniManagerIp: 10.150.144.59 | |||
| versionCheck: false | |||
There was a problem hiding this comment.
remove ip and version check
SparkSnail
reviewed
Jan 5, 2021
nni/experiment/experiment.py
Outdated
| @@ -171,6 +171,7 @@ def run(self, port: int = 8080, debug: bool = False) -> bool: | |||
| while True: | |||
| time.sleep(10) | |||
| status = self.get_status() | |||
| print('zqlllll: ', status) | |||
There was a problem hiding this comment.
What's this line used for?
There was a problem hiding this comment.
sorry, forgot to remove it...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.