[webui] Update default metric tooltip #3316
Conversation
| @@ -25,6 +25,8 @@ const EmptyGraph = { | |||
| interface DefaultPointProps { | |||
| trialIds: string[]; | |||
| visible: boolean; | |||
| chartHeight: number; | |||
| isHasbestCurve: boolean; | |||
ts/webui/src/App.tsx
Outdated
| @@ -6,8 +6,13 @@ import { isManagerExperimentPage } from './static/function'; | |||
| import NavCon from './components/NavCon'; | |||
| import MessageInfo from './components/modals/MessageInfo'; | |||
| import { SlideNavBtns } from './components/slideNav/SlideNavBtns'; | |||
| const echarts = require('echarts/lib/echarts'); | |||
| echarts.registerTheme('my_theme', { | |||
There was a problem hiding this comment.
Maybe "nni_theme" or "nniTheme" is a better name?
There was a problem hiding this comment.
yes, will change it to nni_theme
ts/webui/src/components/Overview.tsx
Outdated
| <Accuracy accuracyData={accuracyGraphData} accNodata={noDataMessage} /> | ||
| <DefaultPoint | ||
| trialIds={bestTrials.map(trial => trial.info.trialJobId)} | ||
| visible={true} |
There was a problem hiding this comment.
I think "visible" can be handled in this level. No need to pass a property into DefaultPoint.
Correct me if it's not the case.
There was a problem hiding this comment.
yes, here no need this visible. And also no need whichGraph. whichGraph is appeared in v0.8 for ant design. It should be deleted when using fabric/fluent because current tab will be uninstall when you choose other tab. So webui doesn't need to consider current tab when page refresh. Thanks for your comment.
|
It seems that is by design: related doc |
#2964