This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
[Retiarii] Improve high-level API interface and add implementation of ValueChoice #3349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
94 tasks
QuanluZhang
reviewed
Feb 2, 2021
QuanluZhang
reviewed
Feb 2, 2021
QuanluZhang
reviewed
Feb 2, 2021
QuanluZhang
reviewed
Feb 2, 2021
|
|
||
| def forward(self, candidate_inputs: List[torch.Tensor]) -> torch.Tensor: | ||
| warnings.warn('You should be run forward of this module directly.') | ||
| return candidate_inputs[0] |
There was a problem hiding this comment.
please double check whether this works in our examples in test
QuanluZhang
approved these changes
Feb 2, 2021
liuzhe-lz
approved these changes
Feb 3, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be done separately in another PR.