This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Add shared storage integration test #3455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acured
force-pushed
the
addSharedStorageTest
branch
from
fb412bc
to
a3c1318
Compare
78 tasks
acured
force-pushed
the
addSharedStorageTest
branch
from
cbfdc27
to
75f9545
Compare
acured
force-pushed
the
addSharedStorageTest
branch
2 times, most recently
from
63e66d3
to
1b73e96
Compare
49 tasks
acured
force-pushed
the
addSharedStorageTest
branch
from
0fc0381
to
3af82d1
Compare
acured
force-pushed
the
addSharedStorageTest
branch
from
3221ce8
to
963e473
Compare
acured
changed the title
J-shang
reviewed
May 19, 2021
test/nni_test/nnitest/run_tests.py
Outdated
| @@ -53,6 +53,18 @@ def update_training_service_config(config, training_service, config_file_path): | |||
| it_ts_config[training_service]['trial']['codeDir'] = containerCodeDir | |||
| it_ts_config[training_service]['trial']['command'] = 'cd {0} && {1}'.format(containerCodeDir, config['trial']['command']) | |||
|
|
|||
| if training_service == 'remote': | |||
| testcase_config = get_yml_content(args.nni_source_dir + config_file_path) | |||
test/nni_test/nnitest/run_tests.py
Outdated
| def match_remoteConfig(test_case_config): | ||
| trainingservice_config = get_yml_content(os.path.join('config', 'training_service.yml')) | ||
| trainingservice_config_reuse_value = str(trainingservice_config['remote']['remoteConfig']['reuse']).lower() | ||
| testcase_config = get_yml_content(args.nni_source_dir + test_case_config['configFile']) |
test/nni_test/nnitest/run_tests.py
Outdated
| @@ -258,6 +279,11 @@ def run(args): | |||
| print('skipped {}, training service {} not match [{}]'.format( | |||
| name, args.ts, test_case_config['trainingService'])) | |||
| continue | |||
|
|
|||
| if not match_remoteConfig(test_case_config): | |||
There was a problem hiding this comment.
a little strange if we do not test remote but we need to judge match_remoteConfig, maybe put these lines under line 288 is better.
| @@ -0,0 +1,24 @@ | |||
| """ | |||
| A deep MNIST classifier using convolutional layers. | |||
|
|
|||
There was a problem hiding this comment.
If we don't use the nni example, I think create a new folder to handle trial code and config parallel with test/config/examples is better.
acured
force-pushed
the
addSharedStorageTest
branch
from
963e473
to
2fab534
Compare
J-shang
approved these changes
May 19, 2021
SparkSnail
approved these changes
May 19, 2021
acured
force-pushed
the
addSharedStorageTest
branch
2 times, most recently
from
fb96d8e
to
045cb62
Compare
acured
force-pushed
the
addSharedStorageTest
branch
2 times, most recently
from
01a91dd
to
0613e57
Compare
added 23 commits
June 22, 2021 10:38
acured
force-pushed
the
addSharedStorageTest
branch
from
0613e57
to
7e45e81
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by NFS mounting issue (maybe port issue). Needs Quanlu's help.