This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
[Retiarii] Export topk models #3464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
78 tasks
QuanluZhang
reviewed
Mar 24, 2021
| @@ -257,16 +259,30 @@ def stop(self) -> None: | |||
| self._dispatcher_thread = None | |||
| _logger.info('Experiment stopped') | |||
|
|
|||
| def export_top_models(self, top_n: int = 1): | |||
| def export_top_models(self, top_k: int = 1, optimize_mode: str = 'maximize', formatter: str = 'code') -> Any: | |||
There was a problem hiding this comment.
it is better to obtain optimize_mode from strategy
There was a problem hiding this comment.
This requires re-designing of strategy as some strategy does not need to know what mode it is by design (e.g., random). I'll add a comment that optimize_mode is likely to be removed and defined in strategy in future.
liuzhe-lz
reviewed
Mar 29, 2021
| @@ -43,6 +44,12 @@ def submit_models(*models: Model) -> None: | |||
| engine.submit_models(*models) | |||
|
|
|||
|
|
|||
| def list_models(*models: Model) -> Iterable[Model]: | |||
There was a problem hiding this comment.
I think it's good to make return type concrete, unless it's likely to change in future.
There was a problem hiding this comment.
I think iterable is fine. Some execution engine might favor to return a generator since there are a lot of models.
liuzhe-lz
approved these changes
Mar 29, 2021
QuanluZhang
approved these changes
Apr 3, 2021
acured
pushed a commit
to acured/nni
that referenced
this pull request
Apr 7, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.