This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
[Model Compression / TensorFlow] Support exporting pruned model #3487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
78 tasks
QuanluZhang
reviewed
Apr 6, 2021
| None | ||
| """ | ||
| _logger.info('Saving model to %s', model_path) | ||
| input_shape = self.compressed_model._build_input_shape # cannot find a public API |
There was a problem hiding this comment.
where is _build_input_shape assigned?
There was a problem hiding this comment.
This is tensorflow's private API.
QuanluZhang
reviewed
Apr 6, 2021
| Export masks to the path when set. | ||
| Because Keras cannot save tensors without a ``Model``, | ||
| this will create a model, set all masks as its weights, and then save that model. | ||
| Masks in saved model will be named by corresponding layer name in compressed model. |
There was a problem hiding this comment.
so even the mask file has different format between pytorch and tensorflow?...
There was a problem hiding this comment.
PyTorch masks are exported as PyTorch tensors. So there's no way to make TF masks compatible.
QuanluZhang
approved these changes
Apr 6, 2021
J-shang
approved these changes
Apr 6, 2021
| self._update_weights() | ||
| return self.layer(*inputs) | ||
|
|
||
| def _update_weights(self): |
There was a problem hiding this comment.
why we split this function?
There was a problem hiding this comment.
Because forward should not be the only allowed place to update weights.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.