This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

fix bug of `Add/Remove` modal #3491

Merged

SparkSnail merged 2 commits into microsoft:master from Lijiaoa:dev-for-column-modal

Apr 2, 2021

Contributor

Lijiaoa commented Mar 29, 2021 •

edited

Loading

description:

this bug is from v2.1
when using parameter graph's Add/Remove axes together with table's Add/Remove columns, it will be confused.
bug’s reason: they all use the component ChangeColumnComponent and it store localstorage by same key
bug fix by add key to make different modal
use localstorage to store user hyper-parameter yAxis setting

Lijiao added 2 commits

March 29, 2021 08:52


          para graph and table columns changes bug

90cae5a


          del unuseful change

e99c793

SparkSnail requested review from ultmaster and J-shang

March 31, 2021 02:53

J-shang approved these changes

View reviewed changes

ultmaster approved these changes

View reviewed changes

SparkSnail merged commit 4338bcb into microsoft:master

acured pushed a commit to acured/nni that referenced this pull request


          fix bug of Add/Remove modal (microsoft#3491)

c2e0fcb

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet