Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

Fix bug of FLOPs counter #3497

Merged
merged 6 commits into from
Apr 21, 2021
Merged

Fix bug of FLOPs counter #3497

merged 6 commits into from
Apr 21, 2021

Conversation

colorjam
Copy link
Contributor

@colorjam colorjam commented Mar 30, 2021 •
edited
Loading

  1. bug of kernel_ops calculation Model FLOPs/Parameters Counter Example #3344
  2. add counters of rnn module

@colorjam colorjam requested review from J-shang and QuanluZhang March 30, 2021 07:23
J-shang
J-shang reviewed Mar 30, 2021
View reviewed changes
nni/compression/pytorch/utils/counter.py Outdated
nn.LSTMCell: self._count_lstm_cell,
nn.RNN: self._count_rnn,
nn.GRU: self._count_gru,
nn.LSTM: self._count_lstm,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just curious, why only conv and linear are supported by default?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most pruning papers target on the classification task and only report results of conv and linear. Move RNN modules to default would be better.

@QuanluZhang
Copy link
Contributor

@colorjam please fix pipeline error

@ultmaster ultmaster changed the base branch from master to v2.2 April 15, 2021 00:50
@SparkSnail SparkSnail merged commit 7fd0776 into microsoft:v2.2 Apr 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@J-shang J-shang J-shang approved these changes

@QuanluZhang QuanluZhang QuanluZhang approved these changes

@andrewchoi5 andrewchoi5 andrewchoi5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@colorjam @QuanluZhang @andrewchoi5 @J-shang @SparkSnail