This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Make selected trials consistent across auto-refresh in detail table #3597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 7, 2021 07:02
ultmaster
reviewed
May 10, 2021
| } | ||
| items.forEach(item => { | ||
| if (item.id === id) { | ||
| item.checked = !!checked; |
There was a problem hiding this comment.
follow the example on fluent doc, look like this picture
ultmaster
approved these changes
May 11, 2021
liuzhe-lz
approved these changes
May 14, 2021
49 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR content:
修的问题：
related changes:
测试用例：
启动一个基本实验（trial 条数 > 10 条），查看 /detail 页面
（1）在 table 中选择几条 trial，观察页面定时刷新时（可以观察 Duration 列来判断是否刷新了）这几条 trial 的选中状态，如果依然是被选中，测试正确，否则，有问题
（2）在（1）的基础上，单机 compare 按钮，会弹出 compare modal，此时，点击页面空白处来关闭 compare modal，table 里选中的 trail 自动被清掉了，测试正确
（3）在（1）的基础上，单机 compare 按钮，会弹出 compare modal，此时，点击 compare modal 框里的 × 按钮来关闭 compare modal，table 里选中的 trial 自动被清掉了，测试正确
（4）在（1）的基础上，单机 tensorboard 按钮，关闭 tensorboard modal 之后，table 里选中的 trial 自动被清掉了，测试正确
（5）使用 table 分页功能，在不同的页里进行 select trial 操作，再翻看之前页里选中的 trial 是不是依然是选中的状态，是选中状态，测试正确