Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

Improve NNI manager logging #3624

Merged
merged 4 commits into from
May 12, 2021
Merged

Conversation

liuzhe-lz
Copy link
Contributor

This PR implements following improvements:

  1. Allow TS loggers to have "name" like Python counterpart, so it can distinguish log messages from different modules. This will be helpful for 3rd party training service.
  2. Correctly format log message to string (rather than array).
  3. Automatically stringify JSON objects and arrays, so you won't see [Object object] in log.

Before:

[2021-04-21 10:37:34] INFO [ 'Datastore initialization done' ]

Now:

[2021-05-10 12:07:56] INFO (root) Datastore initialization done

@ultmaster ultmaster added the enhancement New feature or request label May 10, 2021
@ultmaster ultmaster merged commit 290558c into microsoft:master May 12, 2021
@liuzhe-lz liuzhe-lz deleted the managerlog branch June 17, 2021 03:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants