Improve search parameters on trial detail page #3651
Conversation
ts/webui/src/static/interface.ts
Outdated
| interface SearchItems { | ||
| name: string; | ||
| operator: string; | ||
| value1: string; |
There was a problem hiding this comment.
What are value1 and value2
There was a problem hiding this comment.
value1 is to store firstInput val(user input), it maybe Trial id, Trial No. and parameter value
value2 is to strore secondInput val(user input), it is parameter seconde value, it's operator is between
ts/webui/src/static/const.ts
Outdated
| @@ -2,7 +2,7 @@ | |||
| const METRIC_GROUP_UPDATE_THRESHOLD = 100; | |||
| const METRIC_GROUP_UPDATE_SIZE = 20; | |||
|
|
|||
| const MANAGER_IP = `/api/v1/nni`; | |||
| const MANAGER_IP = `http://13.77.78.63:8080/api/v1/nni`; | |||
| const [trialStatusOperator, setTrialStatusOperator] = useState(getInputsVal()[1]); | ||
| const [firstInputVal, setFirstInputVal] = useState(getInputsVal()[1]); | ||
| const [secondInputVal, setSecondInputVal] = useState(getInputsVal()[2]); | ||
| const operatorList = isStatus ? ['=', '≠'] : ['between', '>', '<', '=', '≠']; |
There was a problem hiding this comment.
I think this check should be by type.
- In case of string: equal, not equal.
- In case of number: between, less, greater, equal, ...
There was a problem hiding this comment.
think about user could input values to search trials, so only parse data type on searching trial function.
search filter list only store origin user input
There was a problem hiding this comment.
So what's the current support for string?
There was a problem hiding this comment.
Please refer to learning_rate:(demo link: http://13.77.78.63:8000/detail)
There was a problem hiding this comment.
Oh. This looks awful. Can we make this unsupported if it's too hard to implement.
(I mean directly removing learning_rate from the dropdown menu)
There was a problem hiding this comment.
delete the support of choice parameter is easy to do...
I'll demo the latest progress in the meeting to confirm the final version!
ts/webui/src/static/function.ts
Outdated
| } else { | ||
| // operator is 'between' | ||
| result = result.filter(trial => trial[parameter] > element.value1 && trial[parameter] < element.value2); | ||
| } |
There was a problem hiding this comment.
We can't filter by metrics now, can we?
There was a problem hiding this comment.
maybe next release:)
|
will push next commit on Sunday~ |
final design: https://www.figma.com/file/HX8Og03m2rwNU1TS6rMTF1/0416-Fluent-Web-NNI-Filter?node-id=40047%3A6959
related issue: #3621
related user issue: #3024
related design issue: #3099 (no use this design)
support:
Trial id, Trial No., Tiral status, Trial parametersat the same timeTrial id, Trial No. and statusEnterto search trial, Please use semicolons to separate conditionslook like:
next release：在 searchBox 里更方便的删除词条
比如，一次退格删以分号为界的一个条件