This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
fix url and api conflict #3672
Merged
fix url and api conflict #3672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ultmaster
reviewed
May 26, 2021
ts/webui/src/static/const.ts
Outdated
| @@ -6,7 +6,7 @@ const METRIC_GROUP_UPDATE_SIZE = 20; | |||
|
|
|||
| const prefix = getPrefix(); | |||
|
|
|||
| const MANAGER_IP = prefix === undefined ? '/api/v1/nni' : `${prefix}`; | |||
| const MANAGER_IP = prefix === undefined ? '/api/v1/nni' : `api/v1/nni${prefix}`; | |||
There was a problem hiding this comment.
prefix should be before /api?
There was a problem hiding this comment.
But when rest api is prefix/api/v1/nni, it still is conflict with ui router. because they are in the same directory prefix/xxx .
There was a problem hiding this comment.
test with ui router ip:port/api/oview and rest api ip:port/api/v1/nni/trial-jobs, webportal is normal!
There was a problem hiding this comment.
Hi @liuzhe-lz , do you have any concern?
There was a problem hiding this comment.
Let's make it work first.
ultmaster
approved these changes
May 27, 2021
liuzhe-lz
approved these changes
May 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.