This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Fix a logging related bug #3705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ultmaster
approved these changes
Jun 1, 2021
SparkSnail
reviewed
Jun 2, 2021
ts/nni_manager/core/nniDataStore.ts
Outdated
| @@ -71,7 +71,7 @@ class NNIDataStore implements DataStore { | |||
|
|
|||
| public storeTrialJobEvent( | |||
| event: TrialJobEvent, trialJobId: string, hyperParameter?: string, jobDetail?: TrialJobDetail): Promise<void> { | |||
| //this.log.debug(`storeTrialJobEvent: event: ${event}, data: ${hyperParameter}, jobDetail: ${JSON.stringify(jobDetail)}`); | |||
| //this.log.debug(`storeTrialJobEvent: event: ${event}, data: ${hyperParameter}, jobDetail:`, jobDetail); | |||
There was a problem hiding this comment.
If this log info is not used, could delete this line.
SparkSnail
approved these changes
Jun 2, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in AML caused by trying to json stringify a circular object for logging.
Now the logging system automatically uses
util.inspect()to print objects. So it's better to avoidJSON.stringify()for logging in case a circular object crashes the whole process and eats the message.This PR also adds tag (class name) to most logging info.