This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Fix 3rd-party training service bug #3726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 4, 2021 15:41
SparkSnail
reviewed
Jun 4, 2021
ts/nni_manager/common/utils.ts
Outdated
| @@ -213,7 +212,7 @@ function cleanupUnitTest(): void { | |||
| Container.restore(TrainingService); | |||
| Container.restore(DataStore); | |||
| Container.restore(Database); | |||
| Container.restore(ExperimentStartupInfo); | |||
| setExperimentStartupInfo(true, 'unittest', 8080, 'unittest', undefined, logLevel); | |||
There was a problem hiding this comment.
Why use 'unittest' as experiment id here?
There was a problem hiding this comment.
The original logic was snapshot ExperimentStartupInfo in prepareUnitTest and restore it here with IOC's utility.
To share ExperimentStartupInfo with 3rd-party training service, it is no longer an IOC container and has to be manually restored.
This line is copied from prepareUnitTest to restore the same state.
SparkSnail
approved these changes
Jun 4, 2021
ultmaster
approved these changes
Jun 4, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Environment service with web command channel needs to know the port. Otherwise it only supports 8080.
To fix this, pass whole ExperimentStartupInfo to environment service.
The template / example training service: https://github.com/liuzhe-lz/nni-training-service-template