Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

[webui] Support dict intermediate metrics(only for number type) #3895

Merged
merged 6 commits into from
Jul 7, 2021
Merged

[webui] Support dict intermediate metrics(only for number type) #3895

merged 6 commits into from
Jul 7, 2021

Conversation

Lijiaoa
Copy link
Contributor

@Lijiaoa Lijiaoa commented Jul 1, 2021

  1. trial intermediate result:

image

  1. compare model:

image

@Lijiaoa
Copy link
Contributor Author

Lijiaoa commented Jul 1, 2021

related issue: #2661

ultmaster
ultmaster reviewed Jul 2, 2021
View reviewed changes
ts/webui/src/components/modals/Compare.tsx
}));

if (trials[0].intermediates !== undefined && trials[0].intermediates[0]) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if trials[0] has empty intermediates?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think empty intermediates is same as x.intermediates is undefined...

@QuanluZhang QuanluZhang mentioned this pull request Jul 2, 2021
Closed
@QuanluZhang QuanluZhang requested a review from acured July 2, 2021 09:10
@QuanluZhang QuanluZhang merged commit 64cf397 into microsoft:master Jul 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@acured acured acured approved these changes

@ultmaster ultmaster ultmaster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Lijiaoa @ultmaster @acured @QuanluZhang