This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Error code for Speedup Module #4173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 10, 2021 08:39
J-shang
reviewed
Sep 13, 2021
|
|
||
| class EmptyLayerError(SpeedupError): | ||
| def __init__(self): | ||
| super(EmptyLayerError, self).__init__("Pruning a Layer to empty is not legal") |
There was a problem hiding this comment.
In this situation, should we suggest the user add this layer in exclude?
There was a problem hiding this comment.
Not exactly the same, there may be two reasons that a layer is pruned to empty: (1) it's sparsity ratio equals to 1.0 (2) it's output is useless after the mask propagation.
|
|
||
| class ShapeMisMatchError(SpeedupError): | ||
| def __init__(self): | ||
| super(ShapeMisMatchError, self).__init__("Shape mismatch!") |
There was a problem hiding this comment.
maybe we can also add layer name in the error message for debugging?
There was a problem hiding this comment.
Good suggestion, but I cannot get the op_name in the module replace functions under current interfaces. To keep the replacement function interface clean, I suggest to just report the error type now.
J-shang
approved these changes
Sep 15, 2021
QuanluZhang
approved these changes
Sep 22, 2021
78 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Error code for speedup module.