An additional parameter keepLines has been added into the formatting options which allows to keep the original line formatting #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…options which allows to keep the original line formatting
aeschli
reviewed
Jul 7, 2022
aeschli
force-pushed
the
aiday/keepNewLines
branch
from
76f1311
to
26a70df
Compare
aeschli
requested changes
Jul 8, 2022
aeschli
reviewed
Jul 11, 2022
src/impl/format.ts
Outdated
| replaceContent = newLineAndIndent(); | ||
| if (options.keepLines && numberLineBreaks > 0 || !options.keepLines) { | ||
| replaceContent = newLinesAndIndent(); | ||
| } else if (options.keepLines) { |
There was a problem hiding this comment.
I think at that point, options.keepLines is always true -> can remove the check
…hanged `withFormatting` so that keepLines option is always false.
aeschli
approved these changes
Jul 11, 2022
This was referenced Sep 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.