Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepare 3.3.0 #90

Merged
merged 4 commits into from
Jun 24, 2024
Merged

prepare 3.3.0 #90

merged 4 commits into from
Jun 24, 2024

Conversation

aeschli
Copy link
Contributor

@aeschli aeschli commented Jun 24, 2024

Also adds exports section to package.json
Closes #78
Closes #56

@aeschli aeschli self-assigned this Jun 24, 2024
@aeschli aeschli enabled auto-merge (squash) June 24, 2024 15:18
@aeschli aeschli merged commit 4f3cf98 into main Jun 24, 2024
5 checks passed
@aeschli aeschli deleted the aeschli/3.3.0 branch June 24, 2024 15:30
This was referenced Jun 24, 2024
@jakebailey
Copy link
Member

jakebailey commented Jun 24, 2024

Unfortunately, this change wasn't right: #78 (comment)

I would also suggest running attw and publint as they both catch the problems:

@remcohaszing
Copy link

remcohaszing commented Jun 24, 2024

I like to use bare imports in tests, so the tests would import 'jsonc-parser'. That, in combination with running tests in both CJS and ESM like #78 does, also ensures package exports work correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants