Do not join the child thread because that gets terminated automatical…

…ly anyways.
microsoft · Oct 25, 2021 · 9c26199 · 9c26199
1 parent 7a22f5d
commit 9c26199
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/src/keyboard_x.cc b/src/keyboard_x.cc
@@ -289,7 +289,9 @@ static void NotifyJS(napi_env env, napi_value func, void* context, void* data) {
 static void FinalizeThreadsafeFunction(napi_env env, void* raw_data, void* hint) {
   NotificationCallbackData *data;
   napi_get_instance_data(env, (void**)&data);
-  pthread_join(data->tid, NULL);
+  // TODO: signal to the other thread that it should break the while (true) loop
+  // only then consider uncommenting the next line:
+  // pthread_join(data->tid, NULL);
   data->tsfn = NULL;
 }