Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conpty breaks ptyProcess.kill() #253

Closed
AvailCat opened this issue Jan 3, 2019 · 0 comments
Closed

Conpty breaks ptyProcess.kill() #253

AvailCat opened this issue Jan 3, 2019 · 0 comments
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug
Milestone
0.8.1

Comments

@AvailCat
Copy link

AvailCat commented Jan 3, 2019

Environment details

  • OS: Windows 10
  • OS version: 1809, 17763.195
  • node-pty version: 0.8.0

Issue description

ptyProcess.kill() doesn't kill anything if conpty was enabled.

See codes this project : examples/killDeepTree
@Tyriar Tyriar mentioned this issue Jan 7, 2019
Closed
@Tyriar Tyriar added this to the 0.8.1 milestone Jan 7, 2019
@Tyriar Tyriar self-assigned this Jan 7, 2019
@Tyriar Tyriar added the bug Issue identified by VS Code Team member as probable bug label Jan 7, 2019
@Tyriar Tyriar mentioned this issue Jan 10, 2019
Closed
@Tyriar Tyriar mentioned this issue Jan 18, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Milestone
0.8.1
Development

No branches or pull requests
2 participants
@Tyriar @AvailCat