Turn on conpty by default for Windows Insiders

[Tyriar]

Need to fix kill bug first

[Tyriar]

microsoft/node-pty#253

[Tyriar]

Build number: 18309

[ghiscoding]

@Tyriar
I was about to log a bug for Conpty and doing some research, I found your issue. I'd like to confirm, that it's the same thing. I'm on Windows Insider Slow Ring (build 17763.253) and for the past few days I had problem running and re-running some Apps using NodeJS. I always had to go in the task manager and kill the NodeJS there were left open even after I close the browser and editor...

Then I remembered I had enable contpy few days ago, I tried disabling the setting and the problem goes away. So all that to say, is that the same bug?

Apart from that, I was happy to see that conpty finally fixes the console being always empty (black) but if it doesn't shut down my NodeJS every time then I guess I'll have to go back to that previous terminal 😢

[Tyriar]

I'm setting the default to false for the v1.31 because of a bad performance issue in Windows Insiders right now, we can probably switch it on for 1.32 unless something like this happens again.

[ghiscoding]

I'm on the Slow Ring and there are still no insiders build available yet for 19H1. I suggest to wait for at least Slow Ring to be at the minimum 18309 that you mentioned, mine is 17xxxx something