Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConPty Insiders Cursor Flashing #66001

Closed
Astrantia opened this issue Jan 4, 2019 · 7 comments
Closed

ConPty Insiders Cursor Flashing #66001

Astrantia opened this issue Jan 4, 2019 · 7 comments
Assignees
Labels
terminal General terminal issues that don't fall under another label

Comments

@Astrantia
Copy link

here

@Astrantia
Copy link
Author

@Tyriar

@Tyriar
Copy link
Member

Tyriar commented Jan 4, 2019

This is a bug in conpty using powershell on Windows 1809, it's fixed on Windows Insiders... I'm considering switching the default back because of this and the performance issues.

@Tyriar Tyriar added this to the December/January 2019 milestone Jan 4, 2019
@Tyriar Tyriar added the terminal General terminal issues that don't fall under another label label Jan 4, 2019
@Tyriar Tyriar self-assigned this Jan 4, 2019
@usernamehw
Copy link
Contributor

Not sure where to put it but Cmder in Insiders is unusable. CPU 100%

screenshot 22

Open and kill terminal a couple of times => always repro for me.

VS Code version: Code - Insiders 1.31.0-insider (7805023, 2019-01-03T06:20:50.629Z)
OS version: Windows_NT x64 10.0.17763

Using a setting helps:

"terminal.integrated.windowsEnableConpty": false,

@Tyriar
Copy link
Member

Tyriar commented Jan 4, 2019

Just disabled it by default, it's opt in now. The kill problem is probably my bad and I've definitely noticed it as well. (perf is another reason that I missed in the commit message)

Tyriar added a commit that referenced this issue Jan 4, 2019
- Cursor flickering in powershell is _really_ annoying and there is no way
  to work around it reliably. It's happening because conpty hides and shows
  the cursor many times when it doesn't really need to, and since data isn't
  batched xterm.js renders as much as possible which shows the cursor in
  positions.
- Kill doesn't kill the process, this is likely a problem on our end.

Part of #66001
@Astrantia
Copy link
Author

Astrantia commented Jan 4, 2019

@Tyriar So basically conpty which was supposed to fix winpty before new Windows Insiders landed faces an issue with 1809 again and needs Insiders too? Why are such critical Windows bugs resolved once every 4 months?

@Tyriar
Copy link
Member

Tyriar commented Jan 4, 2019

@Astrantia Windows 10 is released every 6 months, these weren't considered critical enough to make it in when I surfaced them earlier. It's one of the largest code bases in the world so I can understand the precautions.

@Tyriar
Copy link
Member

Tyriar commented Jan 19, 2019

The fix here is to disable conpty by default in 1809 and enable in the current Windows Insiders, merging into #66158

@Tyriar Tyriar closed this as completed Jan 19, 2019
@Tyriar Tyriar removed this from the December/January 2019 milestone Jan 19, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
terminal General terminal issues that don't fall under another label
Projects
None yet
Development

No branches or pull requests

3 participants