Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

encoding typings are wrong #312

Closed
Tyriar opened this issue May 25, 2019 · 0 comments · Fixed by #362
Closed

encoding typings are wrong #312

Tyriar opened this issue May 25, 2019 · 0 comments · Fixed by #362
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug
Milestone
0.9.0

Comments

@Tyriar
Copy link
Member

Tyriar commented May 25, 2019

When you want a buffer from on('data') encoding needs to be null, however right now only undefined | string are valid.
@Tyriar Tyriar added the bug Issue identified by VS Code Team member as probable bug label May 25, 2019
@Tyriar Tyriar added this to the 0.9.0 milestone May 25, 2019
@Tyriar Tyriar self-assigned this May 25, 2019
Tyriar added a commit that referenced this issue Oct 22, 2019
@Tyriar
Correct encoding types
9520129 
Fixes #312
@Tyriar Tyriar mentioned this issue Oct 22, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Milestone
0.9.0
Development

Successfully merging a pull request may close this issue.

Correct encoding types microsoft/node-pty
1 participant
@Tyriar