ConPTY Support #236
Merged
ConPTY Support #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is the minimum viable "it works" build - it's dirty, it relies on knowing features are coming in the RS5 SDK, and is super fragile.
Clean out dead code, actually define some magic, leave some todo's in areas that need help
|
@Eugeny also be warned the PR isn't complete just yet, the terminal's aren't cleaned up after they exit and no event is fired for example. |
Tyriar
force-pushed
the
dev/migrie/f/conpty
branch
from
5af3c17 to
7125d38
Compare
|
@Tyriar Is this ready to be used in Code Insiders? |
|
@Astrantia very soon 😃 |
|
Let's do this 🚀 💥 😱 🏗 🏎 😎 |
This was referenced Mar 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces ConPTY support to node-pty which will be used when the Windows version is >=17692, there will also be a setting to allow consumers to say which to use.
Fixes #7
Fixes #168
Fixes #216
TODO
NODE_PTY_DEBUGenvironment variable in https://github.com/Microsoft/node-pty/wiki/Debuggingexitdoesn't kill terminal in vscode