Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove experimental from conpty #365

Merged
merged 1 commit into from
Oct 22, 2019
Merged

Remove experimental from conpty #365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/fork/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ var ptyProcess = pty.spawn(shell, [], {
rows: 26,
cwd: isWindows ? process.env.USERPROFILE : process.env.HOME,
env: Object.assign({ TEST: "Environment vars work" }, process.env),
experimentalUseConpty: true
useConpty: true
});

ptyProcess.onData(data => process.stdout.write(data));
Expand Down
2 changes: 1 addition & 1 deletion src/interfaces.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ export interface IPtyForkOptions extends IBasePtyForkOptions {
}

export interface IWindowsPtyForkOptions extends IBasePtyForkOptions {
experimentalUseConpty?: boolean;
useConpty?: boolean;
conptyInheritCursor?: boolean;
}

Expand Down
2 changes: 1 addition & 1 deletion src/windowsTerminal.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ export class WindowsTerminal extends Terminal {
this._deferreds = [];

// Create new termal.
this._agent = new WindowsPtyAgent(file, args, parsedEnv, cwd, this._cols, this._rows, false, opt.experimentalUseConpty, opt.conptyInheritCursor);
this._agent = new WindowsPtyAgent(file, args, parsedEnv, cwd, this._cols, this._rows, false, opt.useConpty, opt.conptyInheritCursor);
this._socket = this._agent.outSocket;

// Not available until `ready` event emitted.
Expand Down
8 changes: 4 additions & 4 deletions typings/node-pty.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,13 +84,13 @@ declare module 'node-pty' {

export interface IWindowsPtyForkOptions extends IBasePtyForkOptions {
/**
* Whether to use the experimental ConPTY system on Windows. When this is not set, ConPTY will
* be used when the Windows build number is >= 18309 (it's available in 17134 and 17692 but is
* too unstable to enable by default).
* Whether to use the ConPTY system on Windows. When this is not set, ConPTY will be used when
* the Windows build number is >= 18309 (instead of winpty). Note that ConPTY is available from
* build 17134 but is too unstable to enable by default.
*
* This setting does nothing on non-Windows.
*/
experimentalUseConpty?: boolean;
useConpty?: boolean;

/**
* Whether to use PSEUDOCONSOLE_INHERIT_CURSOR in conpty.
Expand Down