Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more detailed explanation in case of missing startup file. #238

Merged
merged 2 commits into from
Jul 2, 2015

Conversation

kant2002
Copy link
Contributor

See #6 and #5 for background.

@msftclas
Copy link

Hi @kant2002, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
We will now validate the agreement and then real humans will evaluate your PR.

TTYL, MSBOT;

@kant2002
Copy link
Contributor Author

@mousetraps Could you take a look?

@mousetraps
Copy link
Contributor

Thx for the PR! Much better than what we had before. A couple comments:

  • Pointing people to project properties too would be helpful to those who find it difficult to map Node-isms to VS-isms because it more closely mirrors to the node cmd line args.
  • example filenames aren't necessary, and we can also remove the 'the' before sln explorer to keep the message short and simple.

So how about something like this?

Please select a startup file to launch by right-clicking the file in Solution Explorer and selecting 'Set as Node.js Startup File' or by modifying your configuration in project properties.

@kant2002
Copy link
Contributor Author

kant2002 commented Jul 2, 2015

Agree. That's even better.

to include reference to Project Properties
@kant2002
Copy link
Contributor Author

kant2002 commented Jul 2, 2015

@mousetraps please take a look

mousetraps added a commit that referenced this pull request Jul 2, 2015
Fix #6 - Add more detailed explanation in case of missing startup file.
@mousetraps mousetraps merged commit ace9bf0 into microsoft:master Jul 2, 2015
@kant2002 kant2002 deleted the issue-6 branch July 2, 2015 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants