#233 npm v3 support, #308 VS2015 RTM exceptions on project load #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- support solution explorer tree view - analysis depth optimizations - add .staging to ignored directories - ensure global scope visibility is not limited during analysis microsoft#308 VS2015 RTM exceptions on project load - ensure key is not null before adding package
| _analysisIgnoredDirs = ignoredPaths.Split(';').Select(x => '\\' + x + '\\').ToArray(); | ||
| } else { | ||
| _analysisIgnoredDirs = new string[0]; | ||
| _analysisIgnoredDirs.Append(ignoredPaths.Split(';').Select(x => '\\' + x + '\\').ToArray()); |
There was a problem hiding this comment.
Is _analysisIgnoredDirs just a list? How often is this function called? Is there a risk here of repeatedly appending to the list over time? (If it's a set, this seems safe).
There was a problem hiding this comment.
It gets called on project load, and the ProjectNodes don't get reused on Reload, so it's effectively set.
- updated based on CR - refactored a bit to make things clearer - move RequireAnalysisUnit work to analysis thread to prevent off-thread mutations - add another format for top-level requiredBy string "/" - fixed other misc. issues that came up during testing
- fix issue where some npm trees were not getting created when nodes were duplicated
…o npm3 Conflicts: Nodejs/Product/Nodejs/Extensions.cs
|
Code looks good. I'll merge it in and test it. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#233 npm v3 support
VS2015 RTM Exceptions on Project Load #308 VS2015 RTM exceptions on project load
The bulk of the changes are there, but note that this is not a comprehensive npm v3 changeset - still need to...
These changes are not as risky, though, so I'll file RTM issues for these items if I can't get to them today.