Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#246, #362 - Debugger listening but program not starting, flakey debugger behavior #448

Merged
merged 1 commit into from
Sep 14, 2015

Conversation

mousetraps
Copy link
Contributor

The issue in this case stems from sending an AD7LodCompleteRunningEvent
when we should be sending an AD7LoadCompleteEvent. In particular,
_processLoadedRunning is set to true here even though execution ends up
being paused later.

The fix is to only load the "running" value after modules are loaded,
rather than beforehand.
are loaded, so load the property then rather than beforehand.

Fix #362, fix #246

The issue in this case stems from sending an AD7LodCompleteRunningEvent
when we should be sending an AD7LoadCompleteEvent. In particular,
_processLoadedRunning is set to true here even though execution ends up
being paused later.

The fix is to only load the "running" value after modules are loaded,
rather than beforehand.
are loaded, so load the property then rather than beforehand.
mousetraps added a commit that referenced this pull request Sep 14, 2015
#246, #362 - Debugger listening but program not starting, flakey debugger behavior

The issue in this case stems from sending an AD7LodCompleteRunningEvent
when we should be sending an AD7LoadCompleteEvent. In particular,
_processLoadedRunning is set to true here even though execution ends up
being paused later.

The fix is to only load the "running" value after modules are loaded,
rather than beforehand.
are loaded, so load the property then rather than beforehand.

Fix #362, fix #246
@mousetraps mousetraps merged commit cc4dca9 into microsoft:master Sep 14, 2015
@@ -1152,6 +1149,7 @@ public sealed class AD7Engine : IDebugEngine2, IDebugEngineLaunch2, IDebugProgra
if (_loadComplete) {
SendModuleLoad(adModule);
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this line for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes it easier to read between the lines. I'll remove it 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debugger listening but program not starting Debugger Not Attaching Due to Race Condition in Code
3 participants