Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with Moodle 4.3 #2384

Closed
nbozhkov-ucl opened this issue Oct 3, 2023 · 4 comments
Closed

Issue with Moodle 4.3 #2384

nbozhkov-ucl opened this issue Oct 3, 2023 · 4 comments
Assignees
Labels
Issue type - help wanted General questions on how to use the plugins, e.g. configurations etc. Status - queued / not yet started The request is clear, but the work has yet to be scheduled.

Comments

@nbozhkov-ucl
Copy link

We have been testing the upgrade from Moodle 4.2.2 to Moodle 4.3beta to spot early problems & get fixes before 4.3 official release. After we upgraded succefully, AAD authentication no longer works coming up with the below error message.

Exception - update_internal_user_password(): Argument #2 ($password) must be of type string, null given, called in [dirroot]/lib/moodlelib.php on line 4484

@nbozhkov-ucl
Copy link
Author

Using versions:
auth_oidc 2023042405
local_o365 2023042405

@weilai-irl
Copy link
Collaborator

Hi @nbozhkov-ucl

Thank you for reporting the issue. We haven't started testing the plugins on Moodle 4.3 yet since it hasn't been released. Official support for new Moodle versions are normally added within one month after the release. We have a full set of test cases to run so this may take some time. I'll add the issue reported to the list of items to fix for Moodle 4.3 release.

Regards,
Lai

@weilai-irl weilai-irl added Issue type - help wanted General questions on how to use the plugins, e.g. configurations etc. Status - queued / not yet started The request is clear, but the work has yet to be scheduled. labels Oct 4, 2023
@adminxpcom
Copy link

adminxpcom commented Oct 9, 2023

In admin Page - new Moodle 4.3 (PHP Version 8.2.11):

Deprecated: Creation of dynamic property local_o365\adminsetting\tabs::$component is deprecated in /var/www/html/moo43/local/o365/classes/adminsetting/tabs.php on line 67

Deprecated: Creation of dynamic property local_o365\adminsetting\tabs::$theme is deprecated in /var/www/html/moo43/local/o365/classes/adminsetting/tabs.php on line 68

Deprecated: Creation of dynamic property block_microsoft::$globalconfig is deprecated in /var/www/html/moo43/blocks/microsoft/block_microsoft.php on line 43

Output buffer:
Deprecated: Creation of dynamic property auth_oidc\oidcclient::$scope is deprecated in /var/www/html/moo43/auth/oidc/classes/oidcclient.php on line 93

opitz added a commit to opitz/o365-moodle that referenced this issue Oct 19, 2023
@weilai-irl weilai-irl self-assigned this Nov 2, 2023
@weilai-irl weilai-irl added this to the Moodle 4.3 support milestone Nov 2, 2023
opitz pushed a commit to ucl-isd/moodle-local_o365 that referenced this issue Dec 12, 2023
opitz pushed a commit to ucl-isd/moodle-auth_oidc that referenced this issue Dec 12, 2023
@weilai-irl
Copy link
Collaborator

weilai-irl commented Dec 18, 2023

@nbozhkov-ucl, @opitz

Thank you for reporting and issue and providing solution. The latest release of the plugins from today (v4.3.0, https://moodle.org/plugins/auth_oidc/4.3.0/30700) should fix this one. Please check it out.

Regards,
Lai

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue type - help wanted General questions on how to use the plugins, e.g. configurations etc. Status - queued / not yet started The request is clear, but the work has yet to be scheduled.
Projects
None yet
Development

No branches or pull requests

3 participants