Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Fix issue when deserializing GithubIssueTemplate with hidden secret #1008

Merged
merged 9 commits into from
Jun 24, 2021

Conversation

chkeita
Copy link
Contributor

@chkeita chkeita commented Jun 21, 2021

Fixed issue when deserializing GithubIssueTemplate with hidden secret
Updated unit tests to check the expected data type for SecretData

@chkeita chkeita requested a review from bmc-msft June 21, 2021 23:32
Copy link
Contributor

@bmc-msft bmc-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see feedback regarding cast

@bmc-msft
Copy link
Contributor

Has this change been verified to create github issues end-to-end?

@chkeita
Copy link
Contributor Author

chkeita commented Jun 24, 2021

Has this change been verified to create github issues end-to-end?

yes i was able to successfully create github issues with these changes

@chkeita chkeita closed this Jun 24, 2021
@chkeita chkeita reopened this Jun 24, 2021
@bmc-msft bmc-msft merged commit 5f72cc2 into microsoft:main Jun 24, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jul 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants